Unit testing and close source sync#194
Open
SCDerox wants to merge 16 commits into
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
…orage settings for SQLite.
…ing VIEW_CHANNEL deny. Add regression test.
Contributor
|
Looks good for my modules. Though this will likely conflict with eachother if either get released first with my hotfix PR for my modules, I think you can probably add those changes into this PR, and close mine? Idk |
…ixed and parameter %displayName% added to configuration
Resolves conflict in staff-management.js (kept with-testing's template clone block). Also takes with-testing's commands/ping-protection.js, since the hotfix's brace/list change there targeted the old public structure and broke when combined with the synced version (its functional fix lives in interactionCreate.js, which merged cleanly). All hotfix fixes verified intact.
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes applied to most modules
Unless noted otherwise, the modified modules received some combination of:
@stylistic) conventions (brace spacing, multi-linedestructuring). No behavior change.
module.exports.__test = { ... }) so the logic can beunit-tested. No behavior change.
"migrate inside
botReady.js" approach to the new file-based Umzug migration systemunder
modules/<module>/migrations/.Per-module changes
color-me - author: hfgd
30005and logsfailures with context) and a unit-test export.
connect-four - author: TomatoCake
economy-system - author: jateute
randomIntFromInterval(max, min)with the arguments swapped; corrected to(min, max).economy_User__V1,economy_Cooldown__V1,economy_Shop__V1),replacing the old destructive
sync({force:true})re-insert migration inbotReady.js.console.logstatements that logged user IDs.massrole - author: hfgd
nicknames - author: hfgd
renameMember.jsand the oldbotReady.jsfull re-scan; addedonLoad.js(registers a nickname provider) andpersistExternalEditAsBase.js(persists manual nickname edits as the new base name).guildMemberUpdate.jswasrewritten to drive updates through the manager, skip the guild owner, and detect external edits.
onLoad.js,persistExternalEditAsBase.js) and the manager itself are intentionally lightlycommented; the system is documented in
developer-docs/nickname-manager.md.ping-protection - author: Kevin
safeSetFooterhelper and minor adjustments to theadministrator-permission checks. Behavior otherwise preserved.
quiz - author: TomatoCake
image(with URL validation) andheadline/title. Added thecorresponding slash-command options, config field, and model columns, plus an Umzug migration (
quiz_QuizList__V1).src/functions/parseDurationwrapper.rock-paper-scissors - author: TomatoCake
staff-management-system - author: Kevin
staff-management-system_ActivityCheck__V1).Behavior otherwise preserved.
starboard - author: TomatoCake
awaiton the starboard handlers; fetch partial messages before use; made themember-role check null-safe (
msg.member?.roles).temp-channels - author: hfgd
TextDisplayBuildercomponent when themessage uses
"_schema": "v4", falling back to the previous text append otherwise).TempChannel__V1,__V2) to the Umzug system.twitch-notifications - author: jateute
@twurplev8 (AppTokenAuthProvider); credentials are still read from the module'sconfigs/config.json(twitchClientID/clientSecret).classifyStreamUpdatefunction (exported for unit testing).uno - author: TomatoCake
Fixes #195